Skip to content

webrtc-sys-build: bump zip to 9.0.4 for security advisories - #1532

Merged
xianshijing-lk merged 1 commit into
livekit:mainfrom
drendog:fix/zip-bump
Oct 19, 2026
Merged

xianshijing-lk merged 1 commit into
livekit:mainfrom
drendog:fix/zip-bump

Conversation

@drendog

@drendog drendog commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

the zip crate maintainer yanked all older releases because of 3 security advisories, and while 0.6 was yanked I couldn't use the SDK. It has been un-yanked since, but can still flags it and it could be yanked again, so this moves to 9.0.4

zip-rs/zip2#1075

@drendog
drendog requested a review from ladvoc as a code owner October 17, 2026 19:07
devin-ai-integration[bot]

This comment was marked as resolved.

@CLAassistant

CLAassistant commented Oct 17, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@xianshijing-lk
xianshijing-lk merged commit 8c57055 into livekit:main Oct 19, 2026
35 checks passed
cole-miller added a commit to zed-industries/livekit-rust-sdks that referenced this pull request Oct 29, 2026
Upgrades `webrtc-sys-build`'s `zip` dependency from 0.6 to 9.1 on
`kubkon/zed-patches`, the branch Zed pins. This clears these zip
advisories:

- GHSA-m665-v7pm-7grj: inspection and extraction can see different
filenames. Fixed in 9.0.5.
- GHSA-vv5m-jxxh-4627: extraction keeps SUID/SGID bits.
- GHSA-4684-h2q9-2vcp: extraction can change permissions through a
symlink.

This ports upstream livekit/rust-sdks 8c57055 (livekit#1532). It uses the same
`default-features = false, features = ["deflate-flate2-zlib-rs"]`, but
requires 9.1 instead of upstream's 9.0.4, because 9.0.4 doesn't fix
GHSA-m665-v7pm-7grj. As upstream found, no code changes were needed.

`Cargo.lock` was updated minimally:

- zip 0.6.6 → 9.1.3.
- New zip 9 dependencies: `typed-path`, `zlib-rs`, `nix`, `getrandom`
0.4 and `r-efi`.
- `libc` 0.2.180 → 0.2.191, required by `nix`.
- Removed the bzip2, zstd and AES crates that only zip 0.6's default
features used.

## Verification

- `cargo build -p webrtc-sys-build` and `cargo clippy -p
webrtc-sys-build --all-targets` passed. The only warnings were already
there.
- Called `webrtc_sys_build::download_webrtc()` with a fresh `OUT_DIR`
for `aarch64-apple-darwin` and `x86_64-unknown-linux-gnu`. Both
extracted the expected layout. The mac archive matched `zipinfo` exactly
(29,243 files), and file modes were preserved. The archives contain no
symlinks or SUID/SGID bits.
- Not run: a full `webrtc-sys`/`livekit` build linking the extracted
library, or extraction on Windows or a Linux host.

After this merges, Zed needs to bump its livekit rev to drop zip 0.6.6
from its lockfile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants